arabianq/pipewire-soundpad
1
0
Fork 0
mirror of https://github.com/arabianq/pipewire-soundpad.git synced 2026-04-28 06:21:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

🧹 Fix unsafe unwrap on file path conversion in CLI and GUI

Browse Source 
Replaced `.to_str().unwrap()` with `.to_string_lossy()` when converting
`PathBuf` to `String` to prevent potential crashes if the path contains
invalid Unicode. This change improves the robustness of both the CLI
and GUI components when handling file paths.

- Modified `src/bin/cli.rs` to safely handle `file_path`.
- Modified `src/gui/mod.rs` to safely handle `path` in `play_file`.

Co-authored-by: arabianq <55220741+arabianq@users.noreply.github.com>
This commit is contained in:
google-labs-jules[bot]
2026-03-06 19:52:30 +00:00
parent 624310eae5
commit 47a7674c14
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/bin/cli.rs
+1 -1
View File
@@ -144,7 +144,7 @@ async fn main() -> Result<(), Box<dyn Error>> {
Actions::Play { Actions::Play {
file_path, file_path,
concurrent, concurrent,
} => Request::play(file_path.to_str().unwrap(), concurrent), } => Request::play(&file_path.to_string_lossy(), concurrent),
Actions::ToggleLoop { id } => Request::toggle_loop(id), Actions::ToggleLoop { id } => Request::toggle_loop(id),
}, },
Commands::Get { parameter } => match parameter { Commands::Get { parameter } => match parameter {
src/gui/mod.rs
+1 -1
View File
@@ -113,7 +113,7 @@ impl SoundpadGui {
} }
pub fn play_file(&mut self, path: &PathBuf, concurrent: bool) { pub fn play_file(&mut self, path: &PathBuf, concurrent: bool) {
make_request_async(Request::play(path.to_str().unwrap(), concurrent)); make_request_async(Request::play(&path.to_string_lossy(), concurrent));
} }
pub fn set_input(&mut self, name: String) { pub fn set_input(&mut self, name: String) {